chore: update readme with pin sha in readme#27
Merged
olblak merged 2 commits intoneuvector:mainfrom Mar 31, 2026
Merged
Conversation
Signed-off-by: pohanhuang <pohan.huang@suse.com>
olblak
reviewed
Mar 31, 2026
README.md
Outdated
| docker build -t registry.organization.com/org/image-name:${{ github.sha }} . | ||
| - name: Scan Image | ||
| uses: neuvector/scan-action@main | ||
| uses: neuvector/scan-action@dc98ca3e206249d47f00d884f04dd9905a94f156 |
There was a problem hiding this comment.
It seems like we have releases for this action https://github.com/neuvector/scan-action/releases/tag/1.0.0
Better use 1.0.0 than a commit alone
olblak
reviewed
Mar 31, 2026
README.md
Outdated
| uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 | ||
| - name: Scan Remote Image | ||
| uses: neuvector/scan-action@main | ||
| uses: neuvector/scan-action@dc98ca3e206249d47f00d884f04dd9905a94f156 |
olblak
requested changes
Mar 31, 2026
olblak
left a comment
olblak
left a comment
There was a problem hiding this comment.
We shouldn't use github action digest without comment. We should use version when we can
Signed-off-by: pohanhuang <pohan.huang@suse.com>
olblak
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary